[AutoPR @azure-arm-commerce]-generated-from-SDK Generation - JS-5998147#37597
[AutoPR @azure-arm-commerce]-generated-from-SDK Generation - JS-5998147#37597azure-sdk wants to merge 1 commit into
Conversation
…mmerce/Commerce/tspconfig.yaml', API Version: 2015-06-01-preview, SDK Release Type: beta, and CommitSHA: '087b93bee041c4e1fdc0296b8a96c933689f7a1e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5998147 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 tool issue found in @azure/arm-commerce (v4.0.0-beta.4): the user agent string in the generated context file (src/api/usageManagementContext.ts) is hardcoded to 1.0.0-beta.1 instead of the correct package version 4.0.0-beta.4. The public API surface itself (rename of OfferTermInfoAutoGenerated → OfferTermInfo, introduction of RateCardOperations, UsageAggregatesOperations, KnownVersions, AzureClouds, etc.) shows no guideline violations — no broken client names, no re-ordered constructor parameters, no unknown type-safety issues, no missing exports, and no alpha versions anywhere.
📊 Structured Report
{"agent":"mgmt-reviewer","pr":37597,"summary":"issues_found","findings":[{"file":"sdk/commerce/arm-commerce/src/api/usageManagementContext.ts","line":37,"issueType":"tool","category":"version-mismatch","description":"User agent string is hardcoded to azsdk-js-arm-commerce/1.0.0-beta.1 but package version is 4.0.0-beta.4"}]}⚡ Benchmarked by Management SDK PR Review
| const endpointUrl = | ||
| options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com"; | ||
| const prefixFromOptions = options?.userAgentOptions?.userAgentPrefix; | ||
| const userAgentInfo = `azsdk-js-arm-commerce/1.0.0-beta.1`; |
There was a problem hiding this comment.
🔴 Tool Issue — src/api/usageManagementContext.ts:37
const userAgentInfo = `azsdk-js-arm-commerce/1.0.0-beta.1`;The user agent string embeds 1.0.0-beta.1, but the actual package version in both package.json and CHANGELOG.md is 4.0.0-beta.4. This version mismatch is a generation tool bug — the context file was initialized with an incorrect version.
Fix: Update the user agent string to reflect the correct package version:
const userAgentInfo = `azsdk-js-arm-commerce/4.0.0-beta.4`;Also report this in the generation tool repository so it is not repeated in future regenerations.
|
Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
Bot
added
the
no-recent-activity
|
Hi @azure-sdk. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
2 participants
Configurations: 'specification/commerce/resource-manager/Microsoft.Commerce/Commerce/tspconfig.yaml', API Version: 2015-06-01-preview, SDK Release Type: beta, and CommitSHA: '087b93bee041c4e1fdc0296b8a96c933689f7a1e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5998147 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.